Skip to content

[TOOL-3346] Portal: Add Nebula icon support in dynamic OG image generation #6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

[TOOL-3346] Portal: Add Nebula icon support in dynamic OG image generation #6199

merged 1 commit into from
Feb 7, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 7, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR introduces new metadata and an SVG icon for the nebula component in the thirdweb documentation portal.

Detailed summary

  • Added "nebula" to the metadata options in metadata.ts.
  • Updated the metadata object in layout.tsx with a new image property for nebula.
  • Created a new SVG icon for nebula in nebula.svg with detailed path definitions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 7, 2025

TOOL-3346 Portal: Add Nebula icon support in OG image

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: ecdeebf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:04pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Feb 7, 2025 9:04pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 7, 2025 9:04pm
thirdweb-www ⬜️ Skipped (Inspect) Feb 7, 2025 9:04pm
wallet-ui ⬜️ Skipped (Inspect) Feb 7, 2025 9:04pm

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Feb 7, 2025
@MananTank MananTank marked this pull request as ready for review February 7, 2025 20:50
@MananTank MananTank requested review from a team as code owners February 7, 2025 20:50
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (41d5044) to head (7f3b91d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6199   +/-   ##
=======================================
  Coverage   56.76%   56.76%           
=======================================
  Files        1161     1161           
  Lines       64261    64261           
  Branches     5197     5197           
=======================================
  Hits        36479    36479           
  Misses      27053    27053           
  Partials      729      729
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 41d5044
packages 54.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 584 ms (+99.53% 🔺) 1.6 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 847 ms (+21.85% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 141 ms (+242.3% 🔺) 253 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 37 ms (+325.3% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 324 ms (+562.63% 🔺) 710 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025 •
edited
Loading

Merge activity

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 7, 2025 21:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 7, 2025 21:02 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 7, 2025 21:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 7, 2025 21:02 Inactive
@graphite-app graphite-app bot merged commit 7f3b91d into main Feb 7, 2025
32 checks passed
@graphite-app graphite-app bot deleted the TOOL-3346 branch February 7, 2025 21:05
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 7, 2025 21:05 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 7, 2025 21:05 Inactive
@vercel vercel bot temporarily deployed to Production – login February 7, 2025 21:05 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www February 7, 2025 21:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls